Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events detectors #330

Merged
merged 10 commits into from
Aug 28, 2024
Merged

Events detectors #330

merged 10 commits into from
Aug 28, 2024

Conversation

sofiazcoaga
Copy link
Collaborator

Includes:

  • Storage change events detector: emits a warning when storage is modified in any way and the contract does not emit an event.
  • Storage change events test cases.
  • Token Interface events detector: emits a warning when the token interface trait is implemented and the functions belonging to it that should emit events do not.
  • Token Interface events test cases.

Copy link

github-actions bot commented Aug 20, 2024

🎉 General Rust Workflow Summary 🎉

Component Status
Check Rust Format ✅ Successful
Lint with Clippy ✅ Successful

The workflow has completed. Great job! 🚀

Copy link

github-actions bot commented Aug 20, 2024

🎉 Test Detectors Workflow Summary 🎉

Component Status
Detector Validation ✅ Successful
Build on Ubuntu ✅ Successful
Build on macOS ✅ Successful
Tests Execution ✅ Successful

The workflow has completed. Great job! 🚀

@tenuki
Copy link
Contributor

tenuki commented Aug 26, 2024

sofi check the comments let us know whatever you thinkg about it..

@tenuki tenuki merged commit 9673846 into main Aug 28, 2024
60 checks passed
@tenuki tenuki deleted the events-detectors branch August 28, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants