Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected revert with vector #150

Merged
merged 20 commits into from
May 2, 2024
Merged

Unexpected revert with vector #150

merged 20 commits into from
May 2, 2024

Conversation

sofiazcoaga
Copy link
Collaborator

No description provided.

@sofiazcoaga sofiazcoaga requested a review from tenuki April 19, 2024 19:02
Copy link

github-actions bot commented Apr 19, 2024

🎉 General Rust Workflow Summary 🎉

Component Status
Check Rust Format ✅ Successful
Lint with Clippy ✅ Successful

The workflow has completed. Great job! 🚀

Copy link
Member

@arturoBeccar arturoBeccar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vulnerable and remediated example should be located inside a numbered folder, allowing for new test cases to be added later.

Vulnerable and remediated example should be located inside the following path:

test-cases/dos-unexpected-revert-with-vector/dos-unexpected-revert-with-vector-1

Take as reference https://github.com/CoinFabrik/scout-soroban/tree/main/test-cases/assert-violation/assert-violation-1

Copy link

github-actions bot commented Apr 23, 2024

🎉 Test Detectors Workflow Summary 🎉

Component Status
Detector Validation ✅ Successful
Build on Ubuntu ✅ Successful
Build on macOS ❌ Failed
Tests Execution ❌ Failed

The workflow has completed. Great job! 🚀

@matiascabello matiascabello marked this pull request as draft April 25, 2024 13:43
@matiascabello matiascabello marked this pull request as ready for review April 25, 2024 13:43
@tenuki
Copy link
Contributor

tenuki commented Apr 25, 2024

@sofiazcoaga revisa/resolve lo que hizo notar

@tenuki tenuki dismissed arturoBeccar’s stale review May 2, 2024 17:03

no applies anymore

@tenuki tenuki merged commit 383f960 into main May 2, 2024
48 checks passed
@jgcrosta jgcrosta deleted the unexpected-revert-with-vector branch June 12, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants