Merge pull request #367 from CoinFabrik/detector-information

change detectors description
CoinFabrik · Sep 7, 2024 · 3283949 · 3283949
2 parents 2140f25 + c429f6d
commit 3283949
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/detectors/storage-change-events/src/lib.rs b/detectors/storage-change-events/src/lib.rs
@@ -24,11 +24,11 @@ dylint_linting::impl_late_lint! {
     "",
     StorageChangeEvents::default(),
     {
-        name: "Storage Changed without Emiting an Event",
-        long_message: "",
-        severity: "",
-        help: "",
-        vulnerability_class: "",
+        name: "Storage change event checker",
+        long_message: "Emiting an event when storage changes is a good practice to make the contracts more transparent and usable to its clients and observers",
+        severity: "Enhancement",
+        help: "https://coinfabrik.github.io/scout-soroban/docs/detectors/storage-change-events",
+        vulnerability_class: "Best Practices",
     }
 }
 

diff --git a/detectors/token-interface-events/src/lib.rs b/detectors/token-interface-events/src/lib.rs
@@ -24,11 +24,11 @@ dylint_linting::impl_late_lint! {
     "",
     TokenInterfaceEvents::default(),
     {
-        name: "Storage Changed without Emiting an Event in Token Interface implementations",
-        long_message: " It can originate a problem when a canonical function does not emit an event expected by the contract's clients.",
-        severity: "",
-        help: "",
-        vulnerability_class: "",
+        name: "Token Interface events checker",
+        long_message: "Not emiting the established events breaks compatibility with the token standard and can lead to interoperability problems between the contract and its observers",
+        severity: "Medium",
+        help: "https://coinfabrik.github.io/scout-soroban/docs/detectors/token-interface-events",
+        vulnerability_class: "Standard Compliance",
     }
 }