Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart Editor Additions/Fixes #355

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

TheZoroForce240
Copy link
Contributor

Adds a key count variable into the charter, and swaps out the necessary numbers for it to work properly with different key counts. Also adds 2 new buttons in the "View" drop down to increase/decrease the grid width / key count
Screenshot 2024-07-20 181407

strumlines with a lot of characters now have the icons snap onto a grid and have their scale and position capped out
if a drop down is too large, it can now be scrolled up/down with the mouse wheel, this is mainly to fix a bug with having too many note types
@TheZoroForce240 TheZoroForce240 changed the title Changing Key Count in Chart Editor Chart Editor Additions/Fixes Jul 29, 2024
@TheZoroForce240
Copy link
Contributor Author

Made some changes to how icons on strumlines are positioned/scaled to fix issues with too many characters on one strumline,
This is what it used to look like
Screenshot 2024-07-29 144724
This is what it looks like now
image (4)

Also added the ability to scroll on large drop down menus, mainly to fix a bug with having too many note types breaking the menu

video.mp4

@NexIsDumb
Copy link
Member

NexIsDumb commented Jul 30, 2024

i might marry you
give us a bit of time to merge but trust me you did GREAT

@TheZoroForce240
Copy link
Contributor Author

Reworked again to allow for per strumline key counts
Screenshot 2024-07-30 183024
Screenshot 2024-07-30 183228
Screenshot 2024-07-30 183038
might need some testing since its quite a big change

@Drago-Cuven
Copy link

Drago-Cuven commented Aug 3, 2024

what i'm really going to want is the ability to change key count mid song, and for the chart editor to account for that by changing width of available note slots horizontally.

@ChandelureF-5
Copy link

he is c o o k i n g

@Drago-Cuven
Copy link

what i'm really going to want is the ability to change key count mid song, and for the chart editor to account for that by changing width of available note slots horizontally.

@TheZoroForce240 think that can happen? an event to change keycount midsong, and for the editor to account for that?

@NeeEoo
Copy link
Member

NeeEoo commented Sep 16, 2024

not happening, we are not gonna support keycount changes midsong, if people want that they will have to softcode it

@Drago-Cuven
Copy link

not happening, we are not gonna support keycount changes midsong, if people want that they will have to softcode it

well will the editor at least be more softcoded so that more edits can be made to it?

@NeeEoo
Copy link
Member

NeeEoo commented Sep 16, 2024

not happening, we are not gonna support keycount changes midsong, if people want that they will have to softcode it

well will the editor at least be more softcoded so that more edits can be made to it?

we will see

@Raltyro
Copy link

Raltyro commented Oct 25, 2024

Any progress on this..?

@NeeEoo
Copy link
Member

NeeEoo commented Oct 25, 2024

Its been merged internally

@ChandelureF-5
Copy link

well will the editor at least be more softcoded so that more edits can be made to it?

we will see

huh
well, i never really thought of that, but it would genuinely be awesome if this were the case
i don't wanna force anything though, you guys get to decide on that
after all, it's not my engine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants