Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spark dependencies #1

Merged
merged 4 commits into from
Jul 5, 2024
Merged

Add spark dependencies #1

merged 4 commits into from
Jul 5, 2024

Conversation

cherrera20
Copy link
Collaborator

@cherrera20 cherrera20 commented Jul 4, 2024 •
edited
Loading

  • Add Spark dependencies
  • Do testing with Spark Helper trait.
  • Change CI Java version to 11 because 21 is not compatible with Spark.

JavierCane
JavierCane requested changes Jul 5, 2024
View reviewed changes
src/main/g8/src/test/$package$/$name__Camel$Test.scala Outdated
Comment on lines 3 to 4
import $package$.$name;format="Camel"$
import org.apache.spark.sql.Row
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import $package$.$name;format="Camel"$
import org.apache.spark.sql.Row
import org.apache.spark.sql.Row

src/main/g8/src/test/$package$/SparkTestHelper.scala Outdated
Comment on lines 33 to 34


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

src/main/g8/src/test/$package$/SparkTestHelper.scala Outdated
val metastoreDbPath = new File("metastore_db").getAbsolutePath
FileUtils.deleteDirectory(new File(metastoreDbPath))
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@JavierCane JavierCane merged commit dc3a7e5 into main Jul 5, 2024
1 check passed
@JavierCane JavierCane deleted the addSparkDependencies branch July 5, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JavierCane JavierCane Awaiting requested review from JavierCane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cherrera20 @JavierCane