Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test architecture #361

Merged
merged 6 commits into from
Oct 3, 2023
Merged

feat: test architecture #361

merged 6 commits into from
Oct 3, 2023

Conversation

rgomezcasas
Copy link
Member

@rgomezcasas rgomezcasas commented Oct 3, 2023

To do:

@rgomezcasas rgomezcasas self-assigned this Oct 3, 2023
@github-actions github-actions bot added the size/s label Oct 3, 2023
return PHPat::rule()
->classes(Selector::inNamespace('CodelyTv\Shared\Domain'))
->canOnlyDependOn()
->classes(...array_merge($this->languageClasses(), [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you want to set ignore_built_in_classes: true in the configuration
https://www.phpat.dev/documentation/configuration/

(true will be the default value in the next minor version v0.11.0)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I prefer to keep it disabled, as there are some built-in classes that we consider to be infrastructure (such as Reflection), and we might overlook them.

I would rather manually add all domain built-in classes, accepting the possibility of forgetting to add an Infrastructure class and not receiving an error. 🙌

@rgomezcasas rgomezcasas marked this pull request as ready for review October 3, 2023 17:08
@rgomezcasas rgomezcasas merged commit 0e52a8b into main Oct 3, 2023
2 checks passed
@rgomezcasas rgomezcasas deleted the test-architecture branch October 3, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants