-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: test architecture #361
Conversation
6d8f299
to
4dffdff
Compare
d514647
to
4149186
Compare
4149186
to
4ae23d9
Compare
return PHPat::rule() | ||
->classes(Selector::inNamespace('CodelyTv\Shared\Domain')) | ||
->canOnlyDependOn() | ||
->classes(...array_merge($this->languageClasses(), [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you want to set ignore_built_in_classes: true
in the configuration
https://www.phpat.dev/documentation/configuration/
(true
will be the default value in the next minor version v0.11.0
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I prefer to keep it disabled, as there are some built-in classes that we consider to be infrastructure (such as Reflection), and we might overlook them.
I would rather manually add all domain built-in classes, accepting the possibility of forgetting to add an Infrastructure class and not receiving an error. 🙌
To do: