Added Bedrock Geyser/Floodgate Support #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A6uh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This addresses issue #15 and issue #45 for Geyser incompatibility.
Details:
The issue in both cases is caused by Floodgate (used in conjunction with Geyser as it's required to join Online servers) adding a prefix to bedrock usernames using an illegal character for Java usernames. This character is added to avoid username overlap conflicts and by default is set to "." but can be configured to be any (recommended non-alphanumeric) character. The regex in commands/Time.java:281 was returning Player Not Found if a non-alphanumeric character was used. The changes I've made address this and add the ability to configure the prefix to match what the users have in Floodgate.
I've tested the changes to ensure it was working for these players and will accept any character that Floodgate can use without issue. I've also ensured that users wouldn't have problems updating to this version as the config will now add the floodgate-username-prefix if it doesn't already exist.