Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1211 details tags don't show up inside note #1271

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

SallyMcGrath
Copy link
Member

@SallyMcGrath SallyMcGrath commented Dec 29, 2024

What does this change?

adds goldmark config to tracks because this cannot be inherited from theme

without configuring goldmark anything which does complex mixes of md and html goes wrong. You can tell it's goldmark, or a markdown rendering problem mixing in HTML, because in the rendered view it says <!--raw HTML omitted -->

Fixes #1211

Org Content?

Tracks | hugo.toml

Checklist

Who needs to know about this?

this cannot be inherited, stupidly!
Copy link

netlify bot commented Dec 29, 2024

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 775f3b8
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/67717333715802000831b1e7
😎 Deploy Preview https://deploy-preview-1271--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 29, 2024

Deploy Preview for cyf-common failed. Why did it fail? →

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/6771a025e1dbb34bdac32a51

Copy link

netlify bot commented Dec 29, 2024

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit 775f3b8
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/67717333c9d70a00084405d2

Copy link

netlify bot commented Dec 29, 2024

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 775f3b8
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/677173336cfcc60008412927
😎 Deploy Preview https://deploy-preview-1271--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 29, 2024

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 775f3b8
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/677173331ca1b00008cc57d0
😎 Deploy Preview https://deploy-preview-1271--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 29, 2024

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 775f3b8
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/67717333d6d4bc0008cf75a7
😎 Deploy Preview https://deploy-preview-1271--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 29, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 775f3b8
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/67717333c603c80008142d25
😎 Deploy Preview https://deploy-preview-1271--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 29, 2024

Deploy Preview for cyf-itd ready!

Name Link
🔨 Latest commit 775f3b8
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/67717333bc5f9e0008ef5d66
😎 Deploy Preview https://deploy-preview-1271--cyf-itd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SallyMcGrath SallyMcGrath added this to the Common Theme Release milestone Dec 29, 2024
@SallyMcGrath SallyMcGrath changed the title 1211 <details> tags don't show up inside {{<note>}}s 1211 details tags don't show up inside note Dec 29, 2024
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SallyMcGrath SallyMcGrath merged commit a74330c into main Dec 30, 2024
30 of 34 checks passed
@SallyMcGrath SallyMcGrath deleted the fix/1211-goldmark-config branch December 30, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

<details> tags don't show up inside {{<note>}}s
2 participants