-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NW6| Bakhat Begum| CODEWARS-API-PROJECTS | codeware-API-Project | WEEK-4 #15
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cyf-codewars-projects ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work adapting the component, @BakhatBegum
Just be careful of some comments I have left.
This PR is also missing step 7, which asks for a new web component to be created. I'll move back into "Backlog" on your board so you can complete this last step.
@@ -11,7 +12,14 @@ | |||
<meta name="viewport" content="width=device-width, initial-scale=1" /> | |||
</head> | |||
<body> | |||
<codewars-badge></codewars-badge> | |||
<div class="layout"> | |||
<h1><span>6 kyu </span> BakhatBegum</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you are using data from the API, not hard-coding in the HTML. Your rank will update over time so it needs to change. And if we use the JavaScript for the username, other people could use the page with their own username 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work making this project your own, Bakhat! Just be careful of formatting, it looks like Prettier hasn't formatted this CSS file
Learners, PR Template
Self checklist
Changelist
The pull request is about fetch API, how it works and, what is a web component in HTML file is.
Questions
I would be very happy if you assist me by providing any video regarding fetch and async.