Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NW6| Bakhat Begum| CODEWARS-API-PROJECTS | codeware-API-Project | WEEK-4 #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BakhatBegum
Copy link

@BakhatBegum BakhatBegum commented Jan 26, 2024

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

The pull request is about fetch API, how it works and, what is a web component in HTML file is.

Questions

I would be very happy if you assist me by providing any video regarding fetch and async.

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for cyf-codewars-projects ready!

Name Link
🔨 Latest commit 8fde0a4
🔍 Latest deploy log https://app.netlify.com/sites/cyf-codewars-projects/deploys/65b3c07ac5ee470008a1bd30
😎 Deploy Preview https://deploy-preview-15--cyf-codewars-projects.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JayMayer JayMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work adapting the component, @BakhatBegum

Just be careful of some comments I have left.

This PR is also missing step 7, which asks for a new web component to be created. I'll move back into "Backlog" on your board so you can complete this last step.

@@ -11,7 +12,14 @@
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<codewars-badge></codewars-badge>
<div class="layout">
<h1><span>6 kyu </span> BakhatBegum</h1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you are using data from the API, not hard-coding in the HTML. Your rank will update over time so it needs to change. And if we use the JavaScript for the username, other people could use the page with their own username 🙂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work making this project your own, Bakhat! Just be careful of formatting, it looks like Prettier hasn't formatted this CSS file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants