NW-6 | FATHI_KAHIN | JS1| week 3 exercises | WEEK-3 #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bunday
suggested changes
Dec 9, 2023
| //Answer | ||
|
|
||
|
|
||
| function getAngleType(angle) { |
There was a problem hiding this comment.
great solution, you should take care of negative number, 360
| if (denominator === 0) { | ||
| return undefined; | ||
| } | ||
| if (numerator < denominator && numerator >= 0) { |
There was a problem hiding this comment.
you could have -1/7 this is a proper fraction, your code will say other wise at the moment.
|
|
||
| // If it's after noon (more than 12 o'clock), we will adjust the time format | ||
| if (hours > 12) { | ||
| return `${hours - 12}:00 PM`; |
There was a problem hiding this comment.
you are throwing away the minutes of the time passed into your function. take care of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR. Javascript Week 3 Exercise completed.
Questions
Ask any questions you have for your reviewer.