NW6/Nohe-Tekelmariyam/Module-JS/week-1 #135
Conversation
| @@ -1,4 +1,5 @@ | |||
| // trying to create an age variable and then reassign the value by 1 | |||
|
|
|||
| const age = 33; | |||
| var age = 33; | |||
There was a problem hiding this comment.
That's great you used var to declare the variable age 👍
| @@ -1,7 +1,10 @@ | |||
| const cardNumber = 4533787178994213; | |||
| const last4Digits = cardNumber.slice(-4); | |||
| let stringNumber = cardNumber.toString(); | |||
| const last4Digits =stringNumber.slice(-4); | |||
|
|
|||
| // The last4Digits variable should store the last 4 digits of cardNumber | |||
| // However, the code isn't working | |||
| // Make and explain a prediction about why the code won't work | |||
There was a problem hiding this comment.
Nice one, you could add a little explanation of your prediction as well!
| const HourClockTime12 = "20:53"; | ||
| const hourClockTime24 = "08:53"; | ||
| //variable can not start with numer symbol |
There was a problem hiding this comment.
Well explained! However, the code in line 1 needs a bit more attention!
There was a problem hiding this comment.
can you explain a little bit please?
week-1/exercises/initials.js
Outdated
| @@ -4,3 +4,5 @@ let lastName = "Johnson"; | |||
|
|
|||
| // Declare a variable called initials that stores the first character of each string in upper case to form the user's initials | |||
| // Log the variable in each case | |||
| var initials= `${firstName.charAt(0).toUpperCase()} ${middleName.charAt(0).toUpperCase()}${lastName.charAt(0).toUpperCase()}`; | |||
There was a problem hiding this comment.
You have used the correct methods. Just double-check the output. Can we make it look better?
There was a problem hiding this comment.
what should i change do you think? to make look better?
| // Create a variable to store the ext part of the variable | ||
|
|
There was a problem hiding this comment.
Can you try to create a variable to store the ext part of the variable as well?
| // Try breaking down the expression and using documentation to explain what it means | ||
| // the num variable first find random number 1 up to 100 then round the number | ||
| // and multiplay by maximum -minimum and add one finally add minimum |
There was a problem hiding this comment.
That is right. Also, think about the reason and logic behind doing them and how it works to get what we intended.
week-1/explore/chrome.md
Outdated
| const HourClockTime12 = "20:53"; | ||
| const hourClockTime24 = "08:53"; | ||
| //variable can not start with numer symbol |
There was a problem hiding this comment.
can you explain a little bit please?
week-1/exercises/initials.js
Outdated
| @@ -4,3 +4,5 @@ let lastName = "Johnson"; | |||
|
|
|||
| // Declare a variable called initials that stores the first character of each string in upper case to form the user's initials | |||
| // Log the variable in each case | |||
| var initials= `${firstName.charAt(0).toUpperCase()} ${middleName.charAt(0).toUpperCase()}${lastName.charAt(0).toUpperCase()}`; | |||
There was a problem hiding this comment.
what should i change do you think? to make look better?
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.