This repository has been archived by the owner on Jan 14, 2024. It is now read-only.
generated from CodeYourFuture/CYF-Coursework-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 438
London 9 -Tuan Nguyen-JS-core1-week2 #454
Open
Jacknguyen4438
wants to merge
1
commit into
CodeYourFuture:main
Choose a base branch
from
Jacknguyen4438:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,13 @@ | |
1. the user should be 18 or older | ||
2. the user must be logged in | ||
*/ | ||
function isAcceptableUser(userAge, isLoggedIn) {} | ||
function isAcceptableUser(userAge, isLoggedIn) { | ||
if(userAge >18 && isLoggedIn === true){ | ||
return true; | ||
}else{ | ||
return false; | ||
}; | ||
}; | ||
|
||
/* | ||
Complete the function to apply discount percent based on how much is totalPrice in user cart. | ||
|
@@ -15,26 +21,55 @@ function isAcceptableUser(userAge, isLoggedIn) {} | |
is applieds and 142.5 should be returned) | ||
*/ | ||
|
||
function applyDiscount(totalPrice) {} | ||
function applyDiscount(totalPrice) { | ||
if (totalPrice>200){ | ||
return totalPrice-totalPrice*10/100; | ||
}else{ | ||
return totalPrice-totalPrice*5/100; | ||
} | ||
} | ||
|
||
/* | ||
Complete the function to print to the console the odd numbers between 1 and limit (use a while loop): | ||
*/ | ||
function printOddNumbers(limit) {} | ||
function printOddNumbers(limit) { | ||
let i=1; | ||
while(i < limit){ | ||
if (i%2===1){ | ||
console.log(i); | ||
}; | ||
i++; | ||
}; | ||
|
||
} | ||
|
||
/* | ||
Complete the buyTwoGetTheCheapestFree function: if user buys two items, the cheapest item will be free! | ||
The function should return the price to be paid once the discount is applied. | ||
*/ | ||
function buyTwoGetTheCheapestFree(price1, price2) {} | ||
function buyTwoGetTheCheapestFree(price1, price2) { | ||
if (price1 >price2){ | ||
return price1 | ||
}else{ | ||
return price2 | ||
} | ||
} | ||
|
||
/* | ||
Complete the function to determine if it is suitable for a person to register based on their age! | ||
- if the person is 12 or younger it should return "You Are Too Young To Register" | ||
- if the person is older than 12 and younger than 90 it should return "You Can Register" | ||
- if the person is 90 or older it should return "You Don't Need To Register" | ||
*/ | ||
function canRegister(age) {} | ||
function canRegister(age) { | ||
if (age <= 12){ | ||
return "You Are Too Young To Register"; | ||
}else if (age <90){ | ||
return "You Can Register"; | ||
}else{ | ||
return "You Don't Need To Register"; | ||
}; | ||
}; | ||
|
||
/* | ||
Complete the function so that it prints out to the console numbers in reverse order starting at | ||
|
@@ -45,7 +80,12 @@ function canRegister(age) {} | |
) | ||
*/ | ||
|
||
function countReverse(number) {} | ||
function countReverse(number) { | ||
while (number >0){ | ||
console.log(number); | ||
}; | ||
number=number-1; | ||
}; | ||
Comment on lines
+83
to
+88
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good effort but are you sure this is correct? When you ran this code locally did it work for you correctly? Hint: Have a look at your |
||
|
||
/* ======= TESTS - DO NOT MODIFY ===== */ | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I'm wondering whether you can make it better? You did similar changes already in the
getMood
function. Would that work here too?