Skip to content
This repository has been archived by the owner on Jan 14, 2024. It is now read-only.

London 9 -Tuan Nguyen-JS-core1-week2 #454

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions mandatory/1-fix-functions.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,20 @@

*/

function getMood() {
let isHappy = true;
function getMood(isHappy) {
//let isHappy = true;

if (isHappy) {
if (isHappy === true) {
return "I am happy";
} else {
return "I am not happy";
}
}

function greaterThan10(num) {
let isBigEnough;
let isBigEnough=num;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I'm wondering whether you can make it better? You did similar changes already in the getMood function. Would that work here too?


if (isBigEnough) {
if (isBigEnough >10) {
return "num is greater than 10";
} else {
return "num is not big enough";
Expand Down
52 changes: 46 additions & 6 deletions mandatory/2-function-creation.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@
1. the user should be 18 or older
2. the user must be logged in
*/
function isAcceptableUser(userAge, isLoggedIn) {}
function isAcceptableUser(userAge, isLoggedIn) {
if(userAge >18 && isLoggedIn === true){
return true;
}else{
return false;
};
};

/*
Complete the function to apply discount percent based on how much is totalPrice in user cart.
Expand All @@ -15,26 +21,55 @@ function isAcceptableUser(userAge, isLoggedIn) {}
is applieds and 142.5 should be returned)
*/

function applyDiscount(totalPrice) {}
function applyDiscount(totalPrice) {
if (totalPrice>200){
return totalPrice-totalPrice*10/100;
}else{
return totalPrice-totalPrice*5/100;
}
}

/*
Complete the function to print to the console the odd numbers between 1 and limit (use a while loop):
*/
function printOddNumbers(limit) {}
function printOddNumbers(limit) {
let i=1;
while(i < limit){
if (i%2===1){
console.log(i);
};
i++;
};

}

/*
Complete the buyTwoGetTheCheapestFree function: if user buys two items, the cheapest item will be free!
The function should return the price to be paid once the discount is applied.
*/
function buyTwoGetTheCheapestFree(price1, price2) {}
function buyTwoGetTheCheapestFree(price1, price2) {
if (price1 >price2){
return price1
}else{
return price2
}
}

/*
Complete the function to determine if it is suitable for a person to register based on their age!
- if the person is 12 or younger it should return "You Are Too Young To Register"
- if the person is older than 12 and younger than 90 it should return "You Can Register"
- if the person is 90 or older it should return "You Don't Need To Register"
*/
function canRegister(age) {}
function canRegister(age) {
if (age <= 12){
return "You Are Too Young To Register";
}else if (age <90){
return "You Can Register";
}else{
return "You Don't Need To Register";
};
};

/*
Complete the function so that it prints out to the console numbers in reverse order starting at
Expand All @@ -45,7 +80,12 @@ function canRegister(age) {}
)
*/

function countReverse(number) {}
function countReverse(number) {
while (number >0){
console.log(number);
};
number=number-1;
};
Comment on lines +83 to +88
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good effort but are you sure this is correct? When you ran this code locally did it work for you correctly?
Look closely what you are trying to do with number parameter. Current code will result in never ending loop and will never complete is there a better way?

Hint: Have a look at your printOddNumbers function.


/* ======= TESTS - DO NOT MODIFY ===== */

Expand Down