-
-
Notifications
You must be signed in to change notification settings - Fork 438
Glasgow_6 - Ehdaa_Sakawi - javaScript - Week_2 #453
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ | |
|
||
*/ | ||
|
||
function getMood() { | ||
function getMood(isHappy) { | ||
let isHappy = true; | ||
|
||
if (isHappy) { | ||
|
@@ -21,7 +21,7 @@ function getMood() { | |
} | ||
|
||
function greaterThan10(num) { | ||
let isBigEnough; | ||
let isBigEnough = num >= 10; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks good but here's a question: Is |
||
|
||
if (isBigEnough) { | ||
return "num is greater than 10"; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,11 @@ | |
1. the user should be 18 or older | ||
2. the user must be logged in | ||
*/ | ||
function isAcceptableUser(userAge, isLoggedIn) {} | ||
function isAcceptableUser(userAge, isLoggedIn) { | ||
if (userAge >= 18 && isLoggedIn){ | ||
return "is acceptable" | ||
} | ||
} | ||
Comment on lines
+7
to
+11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not bad but do we need to know when user is not acceptable? |
||
|
||
/* | ||
Complete the function to apply discount percent based on how much is totalPrice in user cart. | ||
|
@@ -14,27 +18,62 @@ function isAcceptableUser(userAge, isLoggedIn) {} | |
The function should return the new price to be paid (e.g. if the totalPrice is 150, a 5% discount | ||
is applieds and 142.5 should be returned) | ||
*/ | ||
var discount; | ||
function applyDiscount(totalPrice) { | ||
if(totalPrice>200){ | ||
discount=10;} | ||
else{ discount=5; | ||
|
||
} | ||
return totalPrice-( totalPrice * discount / 100); | ||
Comment on lines
+22
to
+28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good effort, can we make this code a bit more readable by formatting your if statement? |
||
} | ||
|
||
function applyDiscount(totalPrice) {} | ||
|
||
/* | ||
Complete the function to print to the console the odd numbers between 1 and limit (use a while loop): | ||
*/ | ||
function printOddNumbers(limit) {} | ||
function printOddNumbers(limit) { | ||
let i = 1; | ||
|
||
while (i % 1===0){ | ||
console.log(i); | ||
} | ||
i = i + 1; | ||
} | ||
|
||
/* | ||
Complete the buyTwoGetTheCheapestFree function: if user buys two items, the cheapest item will be free! | ||
The function should return the price to be paid once the discount is applied. | ||
*/ | ||
function buyTwoGetTheCheapestFree(price1, price2) {} | ||
|
||
function buyTwoGetTheCheapestFree(price1, price2) { | ||
let totalPrice = price1 + price2; | ||
if (price1 < price2){ | ||
let discount = price1; | ||
} | ||
return totalPrice - price1; | ||
} | ||
Comment on lines
+48
to
+54
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When you ran your unit tests did they pass for you? consider following
|
||
|
||
|
||
/* | ||
Complete the function to determine if it is suitable for a person to register based on their age! | ||
- if the person is 12 or younger it should return "You Are Too Young To Register" | ||
- if the person is older than 12 and younger than 90 it should return "You Can Register" | ||
- if the person is 90 or older it should return "You Don't Need To Register" | ||
*/ | ||
function canRegister(age) {} | ||
function canRegister(age) { | ||
if (age <= 12){ | ||
return "You Are Too Young To Register" | ||
} | ||
else if (age > 12 && age < 90) { | ||
return "You Can Register" | ||
} | ||
else { | ||
return "You Don't Need To Register" | ||
} | ||
|
||
|
||
|
||
} | ||
|
||
/* | ||
Complete the function so that it prints out to the console numbers in reverse order starting at | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like you have missed 1 more step of your assignment |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? When you ran your unit tests locally did they pass for you?