Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failing states of the tests weren't particularly useful, so:
expect(foo.length).toBe(bar)
->expect(foo).toHaveLength(bar)
, because the latter shows you what was infoo
if its length isn'tbar
- see e.g.jest/prefer-to-have-length
expect(foo[0].bar).toBe(baz)
->expect(foo).toEqual([{ bar: baz }])
again because then the failing test tells you whatfoo
was, rather than "expectedbaz
receivedundefined
" (or crashing withTypeError: Cannot read properties of undefined
)expect(foo).toHaveProperty([0, "bar"], baz)
From Growing Object-Oriented Software by Nat Pryce and Steve Freeman, © 2010 Nat Pryce, released under CC BY-SA 4.0.
Also:
\c videorec;
broke the test seedingawait waitForElementToBeRemoved(deleteButton);
can fail because the same button is reused by React - wait for there to be only one button instead