-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glasgow Class 6 - Christina Mifsud - Full Stack Assessment - Level 300 #411
Conversation
Set up components
Level 100 & Level 250
Signed-off-by: ChristinaMifsud <[email protected]>
Level 200 & Level 300 WIP
Updated POST in front end to communicate with db
Hi @christina-mifsud, Do you have a link to the deployed version of your app, please? I can't run this application locally due to missing environment variables. |
@Dedekind561 My apologies! I had not yet deployed it. Link found here: https://christinamifsud-fullstackassessment.onrender.com/ and in my repo 'About' section. Thanks in advance. |
} | ||
} | ||
|
||
const urlId = url.split("v=")[1].substring(0, 11); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @christina-mifsud,
Thanks for submitting your code - I can see you are trying to debug an error at the moment. Look closely at the data you're getting back from your API ( I can see this being logged in the console
at the moment )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look closely at this data does it make sense why you get a TypeError
in the frontend when your application loads?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your comments Mitch!
I need to add validation to check if URL is a valid youtube URL or not?
const fetchVideos = async () => { | ||
try { | ||
console.log("front end fetch function"); | ||
const response = await fetch(`${backendUrl}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
${backendUrl} is working for me but why is the url not
${backendUrl}/videos` to indicate you're serving the videos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @christina-mifsud,
Thankyou for your submission - I can see lots of effort has gone into this!
First off, be sure to check you've not broken the deployed version of your application in the production environment ( although I appreciate you're submitting your work so far ! )
I've left some advice on how to identify the bug in your code though.
I hope this helps - let me know if you fix it!
Level 300 complete