London 10 -- Kristina Dudnyk -- Fullstack Project Assignment -- DataBases -- 300 #380
Conversation
KristinaDudnyk
changed the title
| url: `https://www.youtube-nocookie.com/embed/${ | ||
| formData.url.match(/v=([a-zA-Z0-9_-]{11})/)[1] | ||
| }`, |
There was a problem hiding this comment.
Can you talk through what this code is doing?
What assumptions are you making, and how confident are you in them? What could go wrong with it if your assumptions are violated?
There was a problem hiding this comment.
It's a regex that returns the first match, which is eleven characters after v= sign
There was a thought that link could have params and queries, depending on user's action.
So that code is preventing this possibility from the very beginning.
client/src/UpdateRating.jsx
Outdated
| const handleUpdate = async () => { | ||
| try { | ||
| const response = await fetch( | ||
| `https://kristinadudnyk-fullstack-project.onrender.com/video/${video.id}`, |
There was a problem hiding this comment.
I've noticed you've put in this URL a few times, and that in each of them you have a localhost:4500 version commented out.
Can you think of a way to make it easier for you to change which server your frontend is talking to for when you want to test things locally?
There was a problem hiding this comment.
A brainy mate suggested that I can use
ssl: {
rejectUnauthorized: false,
},
which makes it run locally
| app.post("/video", async (req, res) => { | ||
| const { title, url } = req.body; | ||
| // console.log("post video req.body", req.body); | ||
| const id = url.split("embed/")[1]; |
There was a problem hiding this comment.
What assumptions are you making about input from users here? What would happen if those violations were violated? How could they be?
There was a problem hiding this comment.
Regex changes it before the request is sent, so it prevents that issue on the front-end side, passing the clean URL to the server.
…nts. Styling of the web page
…na/.local/bin:/home/kristina/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin
No description provided.