Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AboutView Animation Improvements #1915

Merged
merged 1 commit into from
Oct 20, 2024
Merged

AboutView Animation Improvements #1915

merged 1 commit into from
Oct 20, 2024

Conversation

Kihron
Copy link
Contributor

@Kihron Kihron commented Oct 20, 2024

Description

  • Improved the overall animations for the AboutView. For example, AcknowledgementsView and ContributorsView now use a LazyVStack to improve performance. A threshold was also added to the function getScrollAdjustedValue() to avoid unnecessary view updates.

Related Issues

  • None

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Before

Screen.Recording.2024-10-18.at.3.31.19.PM.mov

After

Screen.Recording.2024-10-18.at.3.04.37.PM.mov

@Kihron
- Improved the animations for the AboutView
95cf18f 
- AcknowledgementsView and ContributorsView now use a LazyVStack to improve performance
austincondiff
austincondiff approved these changes Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the blur as the previous screen fades out. Great attention to detail!

0xWDG
0xWDG approved these changes Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@0xWDG 0xWDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice

@FastestMolasses FastestMolasses merged commit 51669a3 into CodeEditApp:main Oct 20, 2024
2 checks passed
@Kihron Kihron deleted the design/improve-about-animations branch October 27, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FastestMolasses FastestMolasses FastestMolasses approved these changes

@0xWDG 0xWDG 0xWDG approved these changes

@austincondiff austincondiff austincondiff approved these changes

@thecoolwinter thecoolwinter Awaiting requested review from thecoolwinter

@tom-ludwig tom-ludwig Awaiting requested review from tom-ludwig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kihron @austincondiff @0xWDG @FastestMolasses