Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Hapi Rewrite #27

Merged
4 commits merged into from
Jan 14, 2015
Merged

Hapi Rewrite #27

4 commits merged into from
Jan 14, 2015

Conversation

wbprice
Copy link
Member

@wbprice wbprice commented Jan 10, 2015

To start, use Overpass API to get all the data in a bounding box.

To start, use Overpass API to get all the data in a bounding box.
@ghost
Copy link

ghost commented Jan 10, 2015

Looks good, just need to add the license file back.

We decided at Stella's to use Affero since we don't know if this would go over 300 lines, so I'll change that and you can merge that change in if you like before we merge this request.

@wbprice
Copy link
Member Author

wbprice commented Jan 11, 2015

@ryayak1460 I added the Affero license and pushed up that commit.

@qwo
Copy link
Member

qwo commented Jan 11, 2015

👍 rebase needed

@ghost
Copy link

ghost commented Jan 13, 2015

Only one thing: we need to return exhibits without requiring a query parameter. Ember.js will want to use the /exhibits route like a model call, so we can't include a bounding box in the request. I forgot about that part, sorry.

Past that, dude, @wbprice: awesome work. OpenShift, Hapi.js rewrite, functional code and Affero? Hell yeah!

@wbprice
Copy link
Member Author

wbprice commented Jan 13, 2015

@ryayak1460 what should a call to /exhibits without any querystring return?

@ghost
Copy link

ghost commented Jan 14, 2015

All exhibits.

On 13 January 2015 08:51:14 GMT-05:00, "W. Blaine Price" [email protected] wrote:

@ryayak1460 what should a call to /exhibits without any querystring
return?


Reply to this email directly or view it on GitHub:
#27 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

@wbprice
Copy link
Member Author

wbprice commented Jan 14, 2015

@ryayak1460 That can be done, but my concern is the the app won't scale well if we're not limiting response size. This person does something with query strings:
http://stackoverflow.com/questions/16506634/ember-route-with-dynamic-filter-search-criterias

@ghost ghost merged commit b8784f8 into Code4HR:hapi-rewrite Jan 14, 2015
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants