Treat nkError reaching patterns.sameTrees as bug

Clyybber · Mar 9, 2024 · 8af2fd6 · 8af2fd6
1 parent 4296976
commit 8af2fd6
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/compiler/sem/patterns.nim b/compiler/sem/patterns.nim
@@ -68,8 +68,10 @@ proc sameTrees*(a, b: PNode): bool =
     of nkIntLiterals: result = a.intVal == b.intVal
     of nkFloatLiterals: result = a.floatVal == b.floatVal
     of nkStrLiterals: result = a.strVal == b.strVal
-    of nkNone, nkEmpty, nkNilLit, nkCommentStmt, nkError:
-      result = true # XXX: Should nkCommentStmt, nkError be handled?
+    of nkNone, nkEmpty, nkNilLit, nkCommentStmt:
+      result = true # Ignore comments
+    of nkError:
+      unreachable()
     of nkType: result = sameTypeOrNil(a.typ, b.typ)
     of nkWithSons:
       if a.len == b.len: