Refactor: libcib: Static-ize a bunch of functions #3071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No code changes otherwise Signed-off-by: Reid Wahl <[email protected]>
No code changes otherwise Signed-off-by: Reid Wahl <[email protected]>
No code changes otherwise Signed-off-by: Reid Wahl <[email protected]>
No code changes otherwise Signed-off-by: Reid Wahl <[email protected]>
No code changes otherwise Signed-off-by: Reid Wahl <[email protected]>
Signed-off-by: Reid Wahl <[email protected]>
No code changes otherwise Signed-off-by: Reid Wahl <[email protected]>
No code changes otherwise Signed-off-by: Reid Wahl <[email protected]>
No code changes otherwise Signed-off-by: Reid Wahl <[email protected]>
No code changes otherwise Signed-off-by: Reid Wahl <[email protected]>
Just for better organization, putting the constructor as close to the top as it can be. No code changes otherwise. Signed-off-by: Reid Wahl <[email protected]>
No code changes otherwise Signed-off-by: Reid Wahl <[email protected]>
No code changes otherwise Signed-off-by: Reid Wahl <[email protected]>
No code changes otherwise Signed-off-by: Reid Wahl <[email protected]>
No code changes otherwise Signed-off-by: Reid Wahl <[email protected]>
No code changes otherwise Signed-off-by: Reid Wahl <[email protected]>
No code changes otherwise Signed-off-by: Reid Wahl <[email protected]>
And move cib_remote_set_connection_dnotify() to below register_notification while we're here, for consistency with cib__remote_new() Signed-off-by: Reid Wahl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these commits should be completely trivial unless I did something stupid. I did these a few days ago as cleanup prior to making changes for T185 (flexible CIB replacement or delete/modify). Since I put that on hold to discuss the approach and work on #3068, I might as well submit these now.