-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #317: Added multiple layer deletion functionality to action bar #333
base: master
Are you sure you want to change the base?
Conversation
@yashdusing can you post a screenshot of how it works? |
@thatbrguy @Ram81 could you please review the changes made ? |
Is this okay? |
@yashdusing Hey, I didn't have time to check it out, maybe @Ram81 could. But from the screenshots, here are my comments:
|
I’ll add something to highlight the selected layers |
Wouldn’t that be the same as the delete button ? |
@yashdusing Hey, I tested your method, good work. I would still prefer if it was like the following:
|
I’ll work on the highlighting part first if it’s possible just to make this pr complete and then implement the above . Is that okay ? |
Your call. Take your time though, there's no rush. |
I thought about it for a while. |
@yashdusing Could you fix the PR message, you might have missed deleting the PR guidelines. As for the multiple delete function, could we have a delete option in the sidebar upon clicking which a checkbox pops next to each node, and all layers which have been checked can be deleted on the press of another button. |
@utsavgarg earlier PR did the same thing (except the checkbox button) you asked. But, I had to shift to the action bar :/. |
@yashdusing Sorry about the confusion, by the sidebar I did mean the one on the left (action bar). |
Adding multiple layer functionality