Skip to content

Commit

Permalink
Remove dependency on github.com/satori/go.uuid (#1085)
Browse files Browse the repository at this point in the history
it has a vulnerability, GO-2020-0018. Although fixed in master (satori/go.uuid#75), a release has never been tagged

Co-authored-by: Kuba Kaflik <[email protected]>
  • Loading branch information
srikanthccv and jkaflik authored Oct 4, 2023
1 parent 78ccf39 commit 3091c87
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
1 change: 0 additions & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ require (
github.com/mkevac/debugcharts v0.0.0-20191222103121-ae1c48aa8615
github.com/paulmach/orb v0.10.0
github.com/pkg/errors v0.9.1
github.com/satori/go.uuid v1.2.0
github.com/shopspring/decimal v1.3.1
github.com/stretchr/testify v1.8.4
github.com/testcontainers/testcontainers-go v0.25.0
Expand Down
2 changes: 0 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,6 @@ github.com/power-devops/perfstat v0.0.0-20210106213030-5aafc221ea8c h1:ncq/mPwQF
github.com/power-devops/perfstat v0.0.0-20210106213030-5aafc221ea8c/go.mod h1:OmDBASR4679mdNQnz2pUhc2G8CO2JrUAVFDRBDP/hJE=
github.com/rogpeppe/go-internal v1.10.0 h1:TMyTOH3F/DB16zRVcYyreMH6GnZZrwQVAoYjRBZyWFQ=
github.com/russross/blackfriday/v2 v2.0.1/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
github.com/satori/go.uuid v1.2.0 h1:0uYX9dsZ2yD7q2RtLRtPSdGDWzjeM3TbMJP9utgA0ww=
github.com/satori/go.uuid v1.2.0/go.mod h1:dA0hQrYB0VpLJoorglMZABFdXlWrHn1NEOzdhQKdks0=
github.com/seccomp/libseccomp-golang v0.9.2-0.20220502022130-f33da4d89646/go.mod h1:JA8cRccbGaA1s33RQf7Y1+q9gHmZX1yB/z9WDN1C6fg=
github.com/segmentio/asm v1.2.0 h1:9BQrFxC+YOHJlTlHGkTrFWf59nbL3XnCoFLTwDCI7ys=
github.com/segmentio/asm v1.2.0/go.mod h1:BqMnlJP91P8d+4ibuonYZw9mfnzI9HfxselHZr5aAcs=
Expand Down
8 changes: 4 additions & 4 deletions tests/uuid_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ package tests

import (
"context"
"testing"

"github.com/ClickHouse/clickhouse-go/v2/lib/column"
suuid "github.com/satori/go.uuid"
"github.com/stretchr/testify/require"
"testing"

"github.com/ClickHouse/clickhouse-go/v2"
"github.com/google/uuid"
Expand Down Expand Up @@ -95,13 +95,13 @@ func TestStringerUUID(t *testing.T) {
batch, err := conn.PrepareBatch(ctx, "INSERT INTO test_uuid")
require.NoError(t, err)
var (
col1Data = suuid.NewV4()
col1Data = uuid.New()
)
require.NoError(t, batch.Append(col1Data))
require.Equal(t, 1, batch.Rows())
require.NoError(t, batch.Send())
var (
col1 suuid.UUID
col1 uuid.UUID
)
require.NoError(t, conn.QueryRow(ctx, "SELECT * FROM test_uuid").Scan(&col1))
assert.Equal(t, col1Data.String(), col1.String())
Expand Down

0 comments on commit 3091c87

Please sign in to comment.