Replace AbstractFloat with Real #194
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
=======================================
Coverage 93.03% 93.03%
=======================================
Files 10 10
Lines 1149 1149
=======================================
Hits 1069 1069
Misses 80 80 ☔ View full report in Codecov by Sentry. |
| @@ -3,7 +3,7 @@ module CreateParametersExt | |||
| import Thermodynamics.Parameters.ThermodynamicsParameters | |||
| import CLIMAParameters as CP | |||
|
|
|||
| ThermodynamicsParameters(::Type{FT}) where {FT <: AbstractFloat} = | |||
| ThermodynamicsParameters(::Type{FT}) where {FT <: Real} = | |||
There was a problem hiding this comment.
Why not remove the restriction altogether? You can test that parameter structs are built with the right type in ClimaAtmos, it may not help much to enforce this here.
There was a problem hiding this comment.
I don’t think it makes sense to have a parameter struct with Ints.
There was a problem hiding this comment.
For sure only some types make sense, it's just you save yourself having to predict them in advance which might save you from having to write PRs like this (or eliminate the slowdown that happens when code doesn't work because of a wrong assumption like this, requiring source code update). Overrestriction of types is typical, so just trying to spread the good word...
This should ensure that we can pass/promote duals through Thermodynamics