Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ClimaParameters T_init_min, with new T_min value #193

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

charleskawczynski
Copy link
Member

Followup to #192

@glwagner
Copy link
Member

Do you want to use ifelse instead of if here?

@charleskawczynski
Copy link
Member Author

Do you want to use ifelse instead of if here?

Not in this PR. I'll follow up on this if/when we fix CliMA/ClimaCore.jl#1602

@charleskawczynski charleskawczynski changed the title Remove use of T_min in SA Use ClimaParameters T_init_min, with new T_min value Feb 13, 2024
@charleskawczynski charleskawczynski added the Launch Buildkite Add label to launch Buildkite label Feb 13, 2024
@trontrytel trontrytel enabled auto-merge February 13, 2024 22:22
@trontrytel trontrytel added this pull request to the merge queue Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (5d3b8e0) 93.03% compared to head (3fa7fd6) 93.04%.

Files Patch % Lines
src/config_numerical_method.jl 61.90% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #193   +/-   ##
=======================================
  Coverage   93.03%   93.04%           
=======================================
  Files          10       10           
  Lines        1149     1150    +1     
=======================================
+ Hits         1069     1070    +1     
  Misses         80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit b67e7f7 Feb 13, 2024
19 of 20 checks passed
@charleskawczynski charleskawczynski deleted the ck/rm_T_min branch June 10, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Launch Buildkite Add label to launch Buildkite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants