Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps and julia version #180

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Update deps and julia version #180

merged 3 commits into from
Jan 19, 2024

Conversation

charleskawczynski
Copy link
Member

This PR:

  • Ditches UnPack (and, technically, drops support for some older julia versions in our test suite, but 🤷🏻)
  • Upgrades Julia in CI
  • Upgrades KernelAbstractions and our GPU tests

Copy link
Member

@nefrathenrici nefrathenrici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing UnPack!
Is there a reason we are updating the GH actions now? I can make this change in other repositories as well.
We should also remove the ci 1.6 merge requirement.

@charleskawczynski
Copy link
Member Author

Thanks for removing UnPack! Is there a reason we are updating the GH actions now? I can make this change in other repositories as well. We should also remove the ci 1.6 merge requirement.

I just haven't gotten around to it. I want to add some kernel benchmark tests, but that required upgrading TD to julia 1.10 for CUDA/KA compatibility. So that was kind of blocking me.

And yes, feel free to upgrade in other repos as well.

Agreed, I'll remove the 1.6 check

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d600e0) 93.06% compared to head (5f1bd59) 93.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   93.06%   93.07%   +0.01%     
==========================================
  Files          10       10              
  Lines        1139     1141       +2     
==========================================
+ Hits         1060     1062       +2     
  Misses         79       79              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charleskawczynski
Copy link
Member Author

Something seems wrong with macos on julia 1.10, seems unrelated to this PR.

@charleskawczynski charleskawczynski merged commit c5a6676 into main Jan 19, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies 🕸️ Launch Buildkite Add label to launch Buildkite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants