-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps and julia version #180
Conversation
922ff87
to
ec66acf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing UnPack!
Is there a reason we are updating the GH actions now? I can make this change in other repositories as well.
We should also remove the ci 1.6 merge requirement.
I just haven't gotten around to it. I want to add some kernel benchmark tests, but that required upgrading TD to julia 1.10 for CUDA/KA compatibility. So that was kind of blocking me. And yes, feel free to upgrade in other repos as well. Agreed, I'll remove the 1.6 check |
ec66acf
to
6996afd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
==========================================
+ Coverage 93.06% 93.07% +0.01%
==========================================
Files 10 10
Lines 1139 1141 +2
==========================================
+ Hits 1060 1062 +2
Misses 79 79 ☔ View full report in Codecov by Sentry. |
Something seems wrong with macos on julia 1.10, seems unrelated to this PR. |
This PR: