Improve the explanation surrounding "virtual temperature" and a hypothetical "density temperature"

[glwagner]

I thought the description could be improved by being a little more explicit. If I've made a mistake, let me know and I can fix it. I also embellished the "side point" by putting it in a box to emphasize that this is additional information that isn't core to understanding the main thread.

[trontrytel]

LGTM!

The need to express everything in temperatures...

[glwagner]

Any idea why tests fail? Something about a variable test_project_toml_formatting that's not defined. It seems unrelated to this PR.

[charleskawczynski]

Any idea why tests fail? Something about a variable test_project_toml_formatting that's not defined. It seems unrelated to this PR.

Yeah, it's unrelated, Aqua's test_project_toml_formatting was removed. I'll open a PR to fix this. Also, this PR LGTM.

[charleskawczynski]

Feel free to rebase and merge

[glwagner]

The need to express everything in temperatures...

😅

Worth noting, I was reading this section because (some) bulk formula compute heat flux using the air-sea difference in virtual temperature. Blame the fluxes...

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (025a07f) 93.02% compared to head (0d97c3e) 93.02%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   93.02%   93.02%           
=======================================
  Files           9        9           
  Lines        1133     1133           
=======================================
  Hits         1054     1054           
  Misses         79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[glwagner]

Note I also changed Aqua.type_piracy to Aqua.type_piracies via JuliaTesting/Aqua.jl#230

[charleskawczynski]

Can we rebase / squash this PR?

[glwagner]

Yes. Not sure how to do that at this point, should I disable auto-merge?

[charleskawczynski]

Yes, you can disable and then re-enable auto merge. Not sure why it didn't merge 🤔

[glwagner]

Superceded by #174