(Try 2) Improve the explanation surrounding "virtual temperature" and a hypothetical "density temperature" #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
=======================================
Coverage 93.02% 93.02%
=======================================
Files 9 9
Lines 1133 1133
=======================================
Hits 1054 1054
Misses 79 79 ☔ View full report in Codecov by Sentry. |
|
@charleskawczynski looks like buildkite won't run for this either |
|
@glwagner, we have a label to launch buildkite in thermodynamics, looks like it's started now 🎉 |
charleskawczynski
approved these changes
Jan 5, 2024
got it |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
I'll go ahead and rebase this PR @glwagner |
charleskawczynski
force-pushed
the
glw/docs-improvement
branch
from
80b04df to
18b70d8
Compare
charleskawczynski
added
Launch Buildkite
|
I think we were experimenting with the buildkite settings, and CI was not working because of that. Hopefully things should be smooth moving forward. |
charleskawczynski
force-pushed
the
glw/docs-improvement
branch
from
18b70d8 to
2b97107
Compare
charleskawczynski
added
Launch Buildkite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #171, trying again now that I have contributor privileges.
From #171:
I thought the description could be improved by being a little more explicit. If I've made a mistake, let me know and I can fix it. I also embellished the "side point" by putting it in a box to emphasize that this is additional information that isn't core to understanding the main thread.