Skip to content

Commit

Permalink
Merge pull request #187 from CliMA/zs/hotfix
Browse files Browse the repository at this point in the history 
remove reference temperature in virtual DSE
  • Loading branch information
@szy21
szy21 authored Jan 24, 2024
2 parents 55092b6 + 0dd1864 commit 1701c9a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Thermodynamics"
uuid = "b60c26fb-14c3-4610-9d3e-2d17fe7ff00c"
authors = ["Climate Modeling Alliance"]
version = "0.11.4"
version = "0.11.5"

[deps]
DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae"
Expand Down
2 changes: 1 addition & 1 deletion src/relations.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2956,7 +2956,7 @@ Virtual dry static energy, given
T_0::FT = TP.T_0(param_set)
cp_d::FT = TP.cp_d(param_set)
T_virt = virtual_temperature(param_set, ts)
return cp_d * (T_virt - T_0) + e_pot
return cp_d * T_virt + e_pot
end

"""
Expand Down
3 changes: 1 addition & 2 deletions test/relations.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,6 @@ end

e_tot = total_energy.(param_set, ts, e_kin, e_pot)
_cp_d = FT(TP.cp_d(param_set))
_T_0 = FT(TP.T_0(param_set))
@test all(
specific_enthalpy.(param_set, ts) .≈
e_int .+
Expand All @@ -667,7 +666,7 @@ end
)
@test all(
virtual_dry_static_energy.(param_set, ts, e_pot) .≈
_cp_d .* (virtual_temperature.(param_set, ts) .- _T_0) .+ e_pot,
_cp_d .* virtual_temperature.(param_set, ts) .+ e_pot,
)

# PhaseEquil
Expand Down

2 comments on commit 1701c9a

@szy21
Copy link
Member Author

@szy21 szy21 commented on 1701c9a Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/99418

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.11.5 -m "<description of version>" 1701c9aa474f43814e5d16373606f5ffd0eb6763
git push origin v0.11.5

Please sign in to comment.