Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed regridding of bathymetry #309

Merged
merged 12 commits into from
Dec 21, 2024
Merged

Conversation

simone-silvestri
Copy link
Collaborator

@simone-silvestri simone-silvestri commented Dec 19, 2024

Regridding of bathymetry requires extending periodic dimensions and subsequent passes where we need to define new grids.

This is not compatible with distributed grids for the moment, so it is better to regrid on the global grid and partition the array in the different cores once this operation is done.

Probably, when we find a better way to smooth the bathymetry (as suggested in #253) we can revisit this simple implementation and split the regridding on different cores.

Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When does this fail? When the global bottom height does not fit on one GPU?

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (ff4b883) to head (d53cf69).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Bathymetry.jl 0.00% 18 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #309   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         34      34           
  Lines       1968    1983   +15     
=====================================
- Misses      1968    1983   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simone-silvestri
Copy link
Collaborator Author

When does this fail? When the global bottom height does not fit on one GPU?

I think so.

@simone-silvestri simone-silvestri merged commit d8992d5 into main Dec 21, 2024
20 checks passed
@simone-silvestri simone-silvestri deleted the ss/distributed-regridding branch December 21, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants