-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distributed regridding of bathymetry #309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When does this fail? When the global bottom height does not fit on one GPU?
…an.jl into ss/distributed-regridding
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 34 34
Lines 1968 1983 +15
=====================================
- Misses 1968 1983 +15 ☔ View full report in Codecov by Sentry. |
I think so. |
Regridding of bathymetry requires extending periodic dimensions and subsequent passes where we need to define new grids.
This is not compatible with distributed grids for the moment, so it is better to regrid on the global grid and partition the array in the different cores once this operation is done.
Probably, when we find a better way to smooth the bathymetry (as suggested in #253) we can revisit this simple implementation and split the regridding on different cores.