-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Examples on GPU for Documentation #104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gregory L. Wagner <[email protected]>
Co-authored-by: Gregory L. Wagner <[email protected]>
Co-authored-by: Gregory L. Wagner <[email protected]>
Co-authored-by: Gregory L. Wagner <[email protected]>
…nto ss/omip-simulation
…jl into ss/omip-with-restoring
navidcy
reviewed
Aug 6, 2024
Comment on lines
+85
to
+89
# - CATKE turbulence closure for vertical mixing, see [`CATKEVerticalDiffusivity`](@ref) | ||
# - WENO-based advection scheme for momentum in the vector invariant form, see [`WENOVectorInvariant`](@ref) | ||
# - WENO-based advection scheme for tracers, see [`WENO`](@ref) | ||
# - `SplitExplicitFreeSurfaceSolver` with 75 substeps, see [`SplitExplicitFreeSurface`](@ref) | ||
# - TEOS-10 equation of state, see [`TEOS10EquationOfState`](@ref) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the docs refs here (i.e. (@ref)
) won't work because they mean to point to the docs of Oceananigans which is a different package.
…cean.jl into ss/documentation-on-caltech
glwagner
reviewed
Aug 7, 2024
glwagner
approved these changes
Aug 9, 2024
…cean.jl into ss/documentation-on-caltech
…cean.jl into ss/documentation-on-caltech
Co-authored-by: Gregory L. Wagner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just a test to check that the documentation build triggers correctly on the GPU on the Caltech cluster and the results are literated correctly.
The setup now is that the documentation build without examples runs through github actions every commit while the documentation with examples runs every commit when the label
Generate docs
is attached (and stops running if we remove the label) and (should) run every time the PR is merged.thanks @Sbozzolo for helping with the setup
preview here: https://clima.github.io/ClimaOceanDocumentation/previews/PR104/