Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair compatability with EnsembleKalmanProcesses v1.1.7 #312

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Jul 31, 2024

Purpose

Content

  • Updates CES examples with new Observations framework without changing functionality
  • removes calls to the now-removed EKP.Observations module
  • removes a useless utility dependent on old observations (and unit tests)
  • extends EKP.get_rng() to remove conflicting definitions and removes a deprecated keyword for additive inflation
  • updated Lorenz compat removing unnecessary pinning of FFTW in Lorenz to 1.3 (indirectly pinning EKP to 1.1.5)
  • added warnings to Cloudy docs and run - that it must be run with the specific commit of Cloudy.

Misc

  • Cloudy example has dependency issues, yet again.
    Trying version 0.3.0 along with EKP relaxing Interpolations dependency to 0.13 -> breaks as v0.3.0 was registered many commits after tagging 0.3.0 in Cloudy
    Trying commit b4fa7e3 (sometime 0.3.0 was tagged but before it was registered as 0.3.0) Cloudy, along with EKP relaxing Interpolations dependency to 0.13 -> works!

  • I have read and checked the items on the review checklist.

@odunbar odunbar force-pushed the orad/compat-ekp117 branch from fcce9be to 69eb4a5 Compare July 31, 2024 22:30
@odunbar odunbar changed the title Orad/compat ekp117 Repair compatability with v1.1.7 Jul 31, 2024
@odunbar odunbar changed the title Repair compatability with v1.1.7 Repair compatability with EnsembleKalmanProcesses v1.1.7 Jul 31, 2024
@odunbar odunbar force-pushed the orad/compat-ekp117 branch from 8c7caee to a37d68e Compare August 1, 2024 00:12
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.29%. Comparing base (acf1051) to head (377b644).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
+ Coverage   88.17%   88.29%   +0.12%     
==========================================
  Files           8        8              
  Lines        1184     1188       +4     
==========================================
+ Hits         1044     1049       +5     
+ Misses        140      139       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

removed unused functionality based on old Observations

typo docs

example typo

format

remove deprecated kw

rm deprecated kw

qualify get_rng

better qualifying get_rng

properly override get_rng

format

try

try to resolve buildkite

add scope

scoping fixed in examples

use shrinkage from EKP

use getter for obs noise cov

getter

shrinkage back

working cloudy example

rm explicit EKP
@odunbar odunbar force-pushed the orad/compat-ekp117 branch from d74d158 to 377b644 Compare August 1, 2024 22:21
@odunbar
Copy link
Collaborator Author

odunbar commented Aug 1, 2024

All tests now pass and buildkite. Docs build, and I have also checked to ensure Cloudy example is working.

Merging...

@odunbar odunbar merged commit b8338a0 into main Aug 1, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems installing the package
1 participant