Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS add author #301

Merged
merged 1 commit into from
Apr 5, 2024
Merged

JOSS add author #301

merged 1 commit into from
Apr 5, 2024

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Apr 5, 2024

Purpose

  • add @nefrathenrici (who has accepted the offer) as an author on the JOSS paper
  • no additional financial acknowledgements required

the review, where I have made the request to add an author:
openjournals/joss-reviews#6372


  • I have read and checked the items on the review checklist.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.27%. Comparing base (acf1051) to head (41aa7b4).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
+ Coverage   88.17%   88.27%   +0.09%     
==========================================
  Files           8        8              
  Lines        1184     1185       +1     
==========================================
+ Hits         1044     1046       +2     
+ Misses        140      139       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odunbar
Copy link
Collaborator Author

odunbar commented Apr 5, 2024

@nefrathenrici has approved this offline.

@odunbar odunbar merged commit 8f3e86b into main Apr 5, 2024
9 of 10 checks passed
@odunbar odunbar requested a review from nefrathenrici April 5, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant