deployment: add arm and aarch deb generation #737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementTsang
changed the title
ClementTsang
force-pushed
the
cargo_deb_arm
branch
from
039b57f to
12173c1
Compare
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
=======================================
Coverage 24.20% 24.20%
=======================================
Files 56 56
Lines 12925 12925
=======================================
Hits 3128 3128
Misses 9797 9797
Continue to review full report at Codecov.
|
ClementTsang
force-pushed
the
cargo_deb_arm
branch
4 times, most recently
from
6a52135 to
36b0762
Compare
ClementTsang
changed the title
ClementTsang
force-pushed
the
cargo_deb_arm
branch
from
61d27d9 to
0a144e7
Compare
|
Might want to wait for cross-rs/cross#716 to potentially have some developments so I could potentially easily do this with cross, after some messing around, it seems like running cargo deb on ARM via GHA is kinda messy... I might still mess around with this in the meantime though. |
ClementTsang
force-pushed
the
cargo_deb_arm
branch
6 times, most recently
from
55baa1c to
a6d3569
Compare
ClementTsang
force-pushed
the
cargo_deb_arm
branch
from
a6d3569 to
537ae2d
Compare
|
Gonna close this for now, I'll open a new PR with a slightly less awful solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A description of the change and what it does. If relevant (such as any change that modifies the UI), please provide screenshots of the change:
Adds arm and aarch64 as targets to build .deb files for in the deployment and nightly workflows.
Issue
If applicable, what issue does this address?
Closes: #736
Testing
Relevant workflows should be run:
Checklist
If relevant, ensure the following have been met:
cargo fmt)README.md, help menu, etc.)