Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fluid burners that produce steam. #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

falsedrow
Copy link

Specifically, py's Oil Burner MK 01.

@falsedrow falsedrow marked this pull request as ready for review October 30, 2023 16:33
@ClaudeMetz
Copy link
Owner

Err, don't think it works like that. This might add the entities, but it doesn't use them properly to calculate stuff, and more.

@ClaudeMetz ClaudeMetz closed this Nov 15, 2023
@falsedrow
Copy link
Author

Can you give me an example of what wouldn't work? There's already support for fluid burners in generate_category_entry.

@ClaudeMetz
Copy link
Owner

Hm maybe I spoke too soon, I'll look into the details at some point then.

@ljgw
Copy link

ljgw commented Feb 21, 2024

Funny, I ran into this issue as well, modified my local generator.lua in the same way (minus the line end..) and after seeing it work in Pyanodons, I came here to find that there was already this PR 😄

If it means anything, this code looks good to me, and works well in Py at least. 👍 from me!

image

@Ifry
Copy link

Ifry commented Jul 24, 2024

@ClaudeMetz did the same thing as OP and @ljgw, and then found this PR
it works as expected for the py Oil Burner

@ClaudeMetz
Copy link
Owner

Yeah I'll have to have another look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants