A translation for Brazilian Portuguese #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Care to take a look @jfresco ? |
|
I would test it myself, but when trying to run the app I get the following error: Apparently the container can't find Github.com for some reason. The problem also happens with the base unaltered code, cloned from the repository. I'm a noob in Docker, so it may be my own fault I can't run the app. |
|
@augusto-herrmann it seems you're working on Windows. Windows development is not supported, although mainly I see two things you should look at:
|
|
Thanks for the tips, @gvilarino. I actually am working on Ubuntu 16.04, not Windows. Setting and env var did get rid of the first warning and timeouts, but then it just hangs after the warnings about Kerberos, even if I run While it is running, I get no response when I access localhost:3000 or 127.0.0.1:3000. BTW, you have done a nice introduction to docker with your docker-workshop. I've just followed it. |
|
Actually, after a while waiting for docker-compose to build, I've got those |
|
I think I give up trying to run the app for testing. Regardless, it should be simple enough for you guys to run it and see if it works. I do not expect there to be any problems with it. |
|
@gvilarino, it turns out that there is no problem with SSH traffic in my network at all. There are three protocols git can use, git, ssh and https. Unfortunately, my network blocks only git, but ssh and https do work. I tried changing package.json to use https instead of git, but in result I get the same error. It turns out one of the dependencies (I do not know which one) depends on the /timaschew/cogent package, but declares this dependency using the git protocol. I don't see any obvious way to override that and make it use ssh or https instead. Any ideas? |
|
@augusto-herrmann sadly, there's no way for us to override that since it's an issue of the package itself. The official way to support more than one protocol for a git dependency is described in the official npm documentation. I guess you could open a PR in their repo with that upgrade, linking to this issue. Also, thanks for following the docker workshop and your kind words <3 |
|
Hi @augusto-herrmann! Amazing job with the translations, thank you very much 👏 It seems that you're missing some UI wirings in order to make the app to switch to Portuguese. For example, there is a menu in the sidebar in which you can choose the language, and Portuguese is missing there:
Do you think you can set up your environment to complete that task? Please let us know. |
|
@gvilarino, the package which is originating the problem is not a direct dependency defined in packages.json. It is further down in the dependency tree. The error message I already pasted above does not include enough information to find out. Do you know how to debug the dependency tree to find out which packages are requiring timaschew/cogent? Thanks, @jfresco! I have now noticed other places where I needed to add the language as well. I hope that's all of them, as I still couldn't solve the problem preventing me to run the app and see myself. |
|
A couple of years later, I tried to run the application on another network. Civic Stack continues to fail to build, but now for an entirely new reason: It now looks like a problem with the civicstack package itself, as it the following command fails: Anyway, my PR looks fine now, I think. Could any of you (@gvilarino, @jfresco) please test that it works, considering that you are able to get the build running? And hopefully accept and deploy it, so that the Portuguese language becomes available at the site? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope I have changed all the necessary files for it to work.
I have tried but failed to get the project running locally for testing.