Update working-practices.md #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR will involve (if I can pull it off) three things: 1/ Changes to this page 2/ Including a new page 3/ Adjusting the menu acc
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Added (hopefully) image
Added (hopefully) menu adjustment
Thanks to Daniel, zapped image. Now I will fix the reference to it.
Changed image to markdown table! (Check it out!)
for more information, see https://pre-commit.ci
|
@hhartingrex I replaced the markdown table with HTML and also made the first column headers to match the image. I think that works better then markdown tables for now and fix the errors around spacing. I created an issue #1091 to explore support for markdown tables. |
Punctuation removed
kristenjernigan
requested changes
Mar 28, 2023
kristenjernigan
approved these changes
Mar 28, 2023
|
@dmundra @ContentBrewmaster Are either of you kindly able to review this prior to merge? Thank you! |
farooqzakhilwal
approved these changes
Mar 28, 2023
dmundra
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
@ContentBrewmaster I am going to approve this and merge it so @hhartingrex can have the changes available to review with the team. Please do still provide feedback and changes that you would like to see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will involve (if I can pull it off) four things:
1/ Changes to this page
2/ Including a new page
3/ Adjusting the menu
4/ Adding image
📚 Documentation preview 📚: https://civicactions-handbook--1090.org.readthedocs.build/en/1090/