Skip to content

Commit

Permalink
Setting the errorformat matching manually for reviewdog. (#1363)
Browse files Browse the repository at this point in the history
* Testing setting the errorformat matching manually for reviewdog.

* Added a comment for reviewdog option change.
  • Loading branch information
dmundra authored Mar 22, 2024
1 parent 3e7ea6a commit 5b11d36
Showing 1 changed file with 15 additions and 2 deletions.
17 changes: 15 additions & 2 deletions .config/remark/remark.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,29 @@ export REMARK_PATHS=$(git diff --diff-filter=AM --name-only "${MASTER}" ':*.md')

if [[ -n "${INPUT_GITHUB_TOKEN:-}" ]]; then
export REVIEWDOG_GITHUB_API_TOKEN="${INPUT_GITHUB_TOKEN}"

# For reviewdog we removed '-f=remark-lint' option because the remark output format changed. A fix has been submitted
# at https://github.com/reviewdog/errorformat/pull/146. Once the fix is merged and deployed to a new version of
# reviewdog we can put the option back and remove -efm options.

remark --rc-path=/usr/src/remarkrc.suggestion --no-color ${REMARK_PATHS} 2>&1 >/dev/null |
reviewdog -f=remark-lint \
reviewdog -efm="%-P%f" \
-efm="%#%l:%c %# %trror %m" \
-efm="%#%l:%c %# %tarning %m" \
-efm="%-Q" \
-efm="%-G%.%#" \
-name="remark-lint-suggestions" \
-reporter="github-pr-check" \
-fail-on-error="false" \
-level="info" \
-tee

remark --rc-path=/usr/src/remarkrc.problem --no-color ${REMARK_PATHS} 2>&1 >/dev/null |
reviewdog -f=remark-lint \
reviewdog -efm="%-P%f" \
-efm="%#%l:%c %# %trror %m" \
-efm="%#%l:%c %# %tarning %m" \
-efm="%-Q" \
-efm="%-G%.%#" \
-name="remark-lint-problem" \
-reporter="github-pr-check" \
-fail-on-error="true" \
Expand Down

0 comments on commit 5b11d36

Please sign in to comment.