This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Increase txtScriptHash.MaxLength to 42 to accommodate 0x prefix #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
merged commit
notatestuser
pushed a commit
to notatestuser/neo-gui-developer
that referenced
this pull request
Nov 3, 2017
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy/pasting a scripthash from the latest version of the View Contract dialog into the Invoke Contract dialog causes the last byte to be truncated, because the 42-byte-long scripthash value with the added 0x prefix does not fit into the maximum length of txtScriptHash which is expecting only 40 bytes.
This has led to some confusion for users, because simply removing the 0x from the beginning of the pasted scripthash leaves a truncated scripthash value which is still incorrect. This fix increases the maximum length of the field to 42 bytes to alleviate this.