[TAN-3370] Revert recent changes to folder visibility in legacy projects (and folders) homepage widget #9801
+75
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@luucvanderzee Looks like the FE changes (with the 3 issues I mentioned in the description) aren't good enough to get this fully working. I am getting an infinite spinner and no admin_publications request on the Homepage when testing locally (with legacy widget, with folder): 
|
luucvanderzee
approved these changes
Dec 16, 2024
jinjagit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See original PR to change folder visibility for reference: #9705
BE changes fully reverted.
@luucvanderzee - 3 differences with FE (please review and advise &/or push any needed changes -Thanks!):
2 major differences:
front/app/containers/HomePage/index.tsxThis file looks very different from original. I have not replaced theremoveNotAllowedParents: true,that was removedfront/app/prefetchData.tsalso looks very different. I have not replaced theremoveNotAllowedParents: true,that was removed1 slight difference
front/app/containers/Admin/pagesAndMenu/containers/ContentBuilder/components/Widgets/Published/index.tsxLooks like this file has changed a little since the original PR to change folder visibility, as the replaced line is 2 lines further down.Changelog
Changed