-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bfix(markdown)!: fix inline html parsing #205
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 2015709823
💛 - Coveralls |
Good effort @aman-singh7, I will review it soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solution looks fine for now. Do check regex for every possible negative cases where it can have fail/in-consistent behavior. Ideally, it's possible to add this functionality in the CircuitVerse/packages markdown engine by parsing the nested content inside blockquote. This will allow us to use any type of md tags inside markdown but it is not in accordance to the GitHub Markdown Spec. The Spec doesn't allow any md tag inside blockquote but jekyll based md does (probably ?).
@manjotsidhu Ok, I will work on the fork of flutter_markdown in CircuitVerse (i.e CircuitVerse/packages) and try to it include it there. 👍 |
Ok, it's upto you. Other way (can be the best way) can also be to introduce custom builder which will build the blockquote in our way. |
Ok cool, I will implement this way 👍 |
@manjotsidhu The custom builder has been implemented. |
Fixes #196
Describe the changes you have made in this PR -
Inline HTML Elements
between backticks (`) are not parsed. So, I have split the content between ` and if there exist HTML elements in between them then omitted the `.Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.