Skip to content

Commit

Permalink
remove ref to container.id
Browse files Browse the repository at this point in the history
Signed-off-by: ChrsMark <[email protected]>
  • Loading branch information
ChrsMark committed Feb 28, 2024
1 parent 92ddfe7 commit 30d99e9
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
6 changes: 0 additions & 6 deletions docs/system/container-metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ This metric is optional.
| Attribute | Type | Description | Examples | Requirement Level |
|---|---|---|---|---|
| [`container.cpu.state`](../attributes-registry/container.md) | string | The CPU state for this data point. A container SHOULD be characterized _either_ by data points with no `state` labels, _or only_ data points with `state` labels. | `user`; `kernel` | Opt-In |
| [`container.id`](../attributes-registry/container.md) | string | Container ID. Usually a UUID, as for example used to [identify Docker containers](https://docs.docker.com/engine/reference/run/#container-identification). The UUID might be abbreviated. | `a3bf90e006b2` | Recommended |

`container.cpu.state` has the following list of well-known values. If one of them applies, then the respective value MUST be used, otherwise a custom value MAY be used.

Expand All @@ -48,9 +47,6 @@ This metric is optional.
<!-- endsemconv -->

<!-- semconv metric.container.memory.usage(full) -->
| Attribute | Type | Description | Examples | Requirement Level |
|---|---|---|---|---|
| [`container.id`](../attributes-registry/container.md) | string | Container ID. Usually a UUID, as for example used to [identify Docker containers](https://docs.docker.com/engine/reference/run/#container-identification). The UUID might be abbreviated. | `a3bf90e006b2` | Recommended |
<!-- endsemconv -->

### Metric: `container.disk.io`
Expand All @@ -68,7 +64,6 @@ This metric is optional.
<!-- semconv metric.container.disk.io(full) -->
| Attribute | Type | Description | Examples | Requirement Level |
|---|---|---|---|---|
| [`container.id`](../attributes-registry/container.md) | string | Container ID. Usually a UUID, as for example used to [identify Docker containers](https://docs.docker.com/engine/reference/run/#container-identification). The UUID might be abbreviated. | `a3bf90e006b2` | Recommended |
| [`disk.io.direction`](../attributes-registry/disk.md) | string | The disk IO operation direction. | `read` | Recommended |
| `system.device` | string | The device identifier | `(identifier)` | Recommended |

Expand All @@ -95,7 +90,6 @@ This metric is optional.
<!-- semconv metric.container.network.io(full) -->
| Attribute | Type | Description | Examples | Requirement Level |
|---|---|---|---|---|
| [`container.id`](../attributes-registry/container.md) | string | Container ID. Usually a UUID, as for example used to [identify Docker containers](https://docs.docker.com/engine/reference/run/#container-identification). The UUID might be abbreviated. | `a3bf90e006b2` | Recommended |
| [`network.io.direction`](../attributes-registry/network.md) | string | The network IO operation direction. | `transmit` | Recommended |
| `system.device` | string | The device identifier | `(identifier)` | Recommended |

Expand Down
5 changes: 0 additions & 5 deletions model/metrics/container.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ groups:
attributes:
- ref: container.cpu.state
requirement_level: opt_in
- ref: container.id

# container.memory.* metrics and attribute group

Check warning on line 15 in model/metrics/container.yaml

View workflow job for this annotation

GitHub Actions / yamllint

[comments-indentation] comment not indented like content
- id: metric.container.memory.usage
Expand All @@ -22,8 +21,6 @@ groups:
Memory usage of the container.
instrument: counter
unit: "By"
attributes:
- ref: container.id

# container.disk.io.* metrics and attribute group
- id: metric.container.disk.io
Expand All @@ -36,7 +33,6 @@ groups:
instrument: counter
unit: "By"
attributes:
- ref: container.id
- ref: disk.io.direction
- ref: system.device

Expand All @@ -52,6 +48,5 @@ groups:
instrument: counter
unit: "By"
attributes:
- ref: container.id
- ref: network.io.direction
- ref: system.device

0 comments on commit 30d99e9

Please sign in to comment.