Skip to content

Commit

Permalink
address review comments
Browse files Browse the repository at this point in the history
Signed-off-by: ChrsMark <[email protected]>
  • Loading branch information
ChrsMark committed Mar 21, 2024
1 parent 9f1a8f0 commit 2875b5f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
9 changes: 5 additions & 4 deletions docs/system/container-metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ linkTitle: Container

### Metric: `container.cpu.time`

This metric is optional.
This metric is [opt-in][MetricOptIn].

<!-- semconv metric.container.cpu.time(metric_table) -->
| Name | Instrument Type | Unit (UCUM) | Description |
Expand All @@ -36,7 +36,7 @@ This metric is optional.

### Metric: `container.memory.usage`

This metric is optional.
This metric is [opt-in][MetricOptIn].

<!-- semconv metric.container.memory.usage(metric_table) -->
| Name | Instrument Type | Unit (UCUM) | Description |
Expand All @@ -51,7 +51,7 @@ This metric is optional.

### Metric: `container.disk.io`

This metric is optional.
This metric is [opt-in][MetricOptIn].

<!-- semconv metric.container.disk.io(metric_table) -->
| Name | Instrument Type | Unit (UCUM) | Description |
Expand All @@ -77,7 +77,7 @@ This metric is optional.

### Metric: `container.network.io`

This metric is optional.
This metric is [opt-in][MetricOptIn].

<!-- semconv metric.container.network.io(metric_table) -->
| Name | Instrument Type | Unit (UCUM) | Description |
Expand All @@ -102,3 +102,4 @@ This metric is optional.
<!-- endsemconv -->

[DocumentStatus]: https://github.com/open-telemetry/opentelemetry-specification/tree/v1.22.0/specification/document-status.md
[MetricOptIn]: https://github.com/open-telemetry/opentelemetry-specification/blob/v1.26.0/specification/metrics/metric-requirement-level.md#opt-in
2 changes: 1 addition & 1 deletion model/metrics/container.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ groups:
- ref: container.cpu.state
requirement_level: opt_in

# container.memory.* metrics and attribute group
# container.memory.* metrics and attribute group
- id: metric.container.memory.usage
type: metric
metric_name: container.memory.usage
Expand Down

0 comments on commit 2875b5f

Please sign in to comment.