Skip to content

Commit

Permalink
lint cleanup & bump version number
Browse files Browse the repository at this point in the history
  • Loading branch information
ChrisMBarr committed May 4, 2024
1 parent 3dbc19c commit 712101d
Show file tree
Hide file tree
Showing 62 changed files with 217 additions and 263 deletions.
25 changes: 22 additions & 3 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"root": true,
"ignorePatterns": ["projects/**/*"],
"plugins": ["@typescript-eslint", "simple-import-sort", "prettier", "only-warn"],
"overrides": [
{
"files": ["*.ts"],
Expand All @@ -9,9 +9,11 @@
"project": ["tsconfig.(app|spec|server).json"]
},
"extends": [
"plugin:@angular-eslint/recommended",
"plugin:@angular-eslint/template/process-inline-templates",
"plugin:@typescript-eslint/strict-type-checked",
"plugin:@typescript-eslint/stylistic-type-checked",
"plugin:@angular-eslint/recommended",
"plugin:@angular-eslint/template/process-inline-templates",
"plugin:prettier/recommended"
],
"rules": {
Expand Down Expand Up @@ -44,6 +46,7 @@
"@typescript-eslint/return-await": "warn",

//Typescript specific rules
"@typescript-eslint/no-empty-function":"off",
"@typescript-eslint/no-non-null-assertion": "off",
"@typescript-eslint/array-type": [
"warn",
Expand Down Expand Up @@ -92,10 +95,26 @@

//Regular ESLint rules
"array-callback-return": "warn",
"sort-imports": ["warn", { "allowSeparatedGroups": true }],
"complexity": ["warn", { "max": 8 }],
"eqeqeq": ["warn", "always", { "null": "ignore" }],
"object-shorthand": ["warn", "always"],
"simple-import-sort/imports": "warn",

"no-restricted-imports": [
"warn",
{
"patterns": [
{
"group": ["rxjs/internal/*"],
"message": "Don't import from 'rxjs/internal/*', this can cause optimization bailouts. See this for more details: https://bobbyhadz.com/blog/angular-commonjs-or-amd-dependencies-can-cause-optimization-bailouts "
},
{
"group": ["src/*"],
"message": "Please use a relative import path beginning with './' or '../' so they can be more easily sorted and grouped"
}
]
}
],

"prettier/prettier": [
"warn",
Expand Down
3 changes: 2 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,6 @@
"*.ts": "${capture}.spec.ts",
"tsconfig.json": "tsconfig.*.json",
"package.json": "package-lock.json, yarn.lock, pnpm-lock.yaml, bun.lockb"
}
},
"typescript.preferences.importModuleSpecifier": "relative"
}
Loading

0 comments on commit 712101d

Please sign in to comment.