Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Ninja with ClangCL for CI builds #351

Merged
merged 10 commits into from
Feb 26, 2024
Prev Previous commit
Next Next commit
Trying to fix arg quotes
jatinchowdhury18 committed Feb 26, 2024
commit 96130c9db0aa71175c64320fec251665ef6039eb
4 changes: 2 additions & 2 deletions .github/workflows/cmake.yml
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@ jobs:
- os: ubuntu-22.04
cmake_args: "-DCMAKE_CXX_COMPILER=g++-11"
- os: windows-2022
cmake_args: -G"Ninja Multi-Config" -DCMAKE_C_COMPILER=clang-cl -DCMAKE_CXX_COMPILER=clang-cl
cmake_args: -G\"Ninja Multi-Config\" -DCMAKE_C_COMPILER=clang-cl -DCMAKE_CXX_COMPILER=clang-cl
- os: macos-13
cmake_args: "-DCMAKE_BUILD_TYPE=Release"

@@ -86,7 +86,7 @@ jobs:
CMAKE_ARGS: ${{ matrix.cmake_args }}
CONFIGURE_ADD_ONS_FLAG: "${{ github.event_name != 'pull_request' && '-DBYOD_BUILD_ADD_ON_MODULES=ON' || '' }}"
shell: bash
run: cmake -Bbuild $CONFIGURE_ADD_ONS_FLAG $CMAKE_ARGS
run: cmake -Bbuild $CONFIGURE_ADD_ONS_FLAG "$CMAKE_ARGS"

- name: Build
shell: bash