Do not list devices with a zero size #2
Conversation
|
I'm not so sure we want to do that - installing on an SD card is a very common use case for handheld devices. |
SD cards will still be listed, just not devices with a zero size such as card readers. Card readers may appear as a block device even when no card is inserted. sdc 8:32 1 0B 0 disk |
core/systems/frzr/frzr.gd
Outdated
| @@ -35,6 +35,8 @@ func get_available_disks() -> Array[Disk]: | |||
| if not line.contains("disk"): | |||
| continue | |||
| var parts := line.split(" ", false, 3) | |||
| if parts[2] as int == 0: | |||
There was a problem hiding this comment.
The output of lsblk --list -n -o name,type,size,model will show the size along with a unit (e.g. 1G, 0B). This should be updated to match on that pattern, instead of casting to an int.
E.g.
| if parts[2] as int == 0: | |
| if parts[2] == "0B": |
There was a problem hiding this comment.
Done! Thanks!
I observed that in GDscript if you pass it a string as int it will remove all non-int characters, is my observation correct? I am unable to replicate the behaviour in Python.
This will avoid block devices with a zero size from being listed. Imagine devices such as SD card readers.