Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first pass at using @chia_command without a group #19040

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Dec 12, 2024

Purpose:

with click you can both @some_group.command() to add a new command or some_group.add_command(). This makes it possible to code both with a command -> group dependency or a group -> command dependency depending on the situation. this pr makes the second pattern possible via the new get_chia_command_metadata() function. it is also applied to the chia.cmds.signer module to eliminate a circular dependency with the chia.cmds.wallet module.

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Dec 12, 2024
@altendky altendky marked this pull request as ready for review December 13, 2024 00:15
@altendky altendky requested a review from a team as a code owner December 13, 2024 00:15
@altendky altendky requested a review from emlowe December 13, 2024 00:18
Copy link
Contributor

File Coverage Missing Lines
chia/cmds/cmd_classes.py 92.3% lines 278
Total Missing Coverage
46 lines Unknown 97%

Copy link

Pull Request Test Coverage Report for Build 12303027967

Details

  • 45 of 46 (97.83%) changed or added relevant lines in 5 files are covered.
  • 27 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.002%) to 91.519%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/cmds/cmd_classes.py 12 13 92.31%
Files with Coverage Reduction New Missed Lines %
chia/data_layer/data_store.py 1 95.47%
chia/timelord/timelord.py 1 80.0%
chia/daemon/keychain_proxy.py 1 73.16%
chia/farmer/farmer.py 1 73.32%
chia/daemon/client.py 1 74.01%
chia/server/node_discovery.py 2 82.02%
chia/server/server.py 4 81.9%
chia/server/address_manager.py 7 90.48%
chia/full_node/full_node.py 9 86.55%
Totals Coverage Status
Change from base Build 12301024853: 0.002%
Covered Lines: 104730
Relevant Lines: 114246

💛 - Coveralls

@pmaslana pmaslana merged commit 78afe07 into main Dec 13, 2024
363 of 364 checks passed
@pmaslana pmaslana deleted the chia_command_without_group branch December 13, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants