Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove min function call from debug statement in the clean service function #94

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

tynanford
Copy link
Contributor

@jacomago I ran into this log statement which was causing a runtime error when findSizeLimit wasn't defined in my configuration file.

First I was going to change this to self.conf.get but then it seemed like this isn't necessary here? Since get_active_channels is already called and it's returned value is the channels arg in clean_channels?

@tynanford tynanford requested a review from jacomago August 7, 2024 23:51
Copy link
Contributor

@jacomago jacomago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shroffk shroffk merged commit 9a16bb7 into ChannelFinder:master Aug 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants