add iocIP prop by default, pvaPort and caPort as optional properties that default on (opt-out) #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tynanford
changed the title
This was referenced Jun 14, 2024
|
|
@shroffk is this okay to merge? |
shroffk
approved these changes
Jul 18, 2024
|
This PR implements the improvements discussed during the codeathon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses this issue ticket #90
Adds a new default property
iocIPand adds a new preference settingsiocConnectionInfowhich defaults to on. If this property is enabled, the other two port properties will also be sent to channel finder -pvaPortandcaPort. A user who does not want these properties can toggleiocConnectionInfoto off.In the case reccaster or EPICS base is an older version that does not support RSRV_SERVER_PORT or PVAS_SERVER_PORT (or QSRV is not enabled), recceiver will just skip adding this property to the channel.