Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up package and tests #32

Merged
merged 12 commits into from
Jun 19, 2024
Merged

Clean up package and tests #32

merged 12 commits into from
Jun 19, 2024

Conversation

jacomago
Copy link
Contributor

Swaps the packaging to using pyproject.toml
Adds the test containers library for running tests with a containerized ChannelFinder
Adds testing to CI
Fixes the ChannelFinderClient tests for the current Channelfinder api.

jacomago added 8 commits April 3, 2024 16:07
Turns off aa intergration to reduce logs
Sets EPICS_PVAS_INTF_ADDR_LIST to remove need for ipv6 network
remove "links" depreceated by docker
Sets elasticsearch to 8.11.4 which syncs with ChannelFinderService repo
@jacomago jacomago marked this pull request as draft April 23, 2024 09:31
Add development and testing section.
@jacomago jacomago marked this pull request as ready for review April 23, 2024 11:47
@jacomago jacomago requested a review from tynanford April 23, 2024 11:47
@tynanford
Copy link
Contributor

RHEL 8 ships with python 3.6.8 and will be in support til 2029, could we keep that as the minimum version instead of 3.8?

@jacomago jacomago marked this pull request as draft June 17, 2024 07:55
@jacomago jacomago force-pushed the pyprojecttoml branch 5 times, most recently from c5f41cc to 7893a4b Compare June 17, 2024 08:23
Update ci.yml dependencies
Update pyproject.toml to add support down to 3.6
Update ci.yml to test down to 3.6
Copy link

sonarqubecloud bot commented Jun 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8.0% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@jacomago jacomago marked this pull request as ready for review June 17, 2024 09:29
@jacomago jacomago requested a review from shroffk June 18, 2024 09:21
@jacomago jacomago merged commit c7f426a into master Jun 19, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants