-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up package and tests #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns off aa intergration to reduce logs Sets EPICS_PVAS_INTF_ADDR_LIST to remove need for ipv6 network remove "links" depreceated by docker Sets elasticsearch to 8.11.4 which syncs with ChannelFinderService repo
Add development and testing section.
RHEL 8 ships with python 3.6.8 and will be in support til 2029, could we keep that as the minimum version instead of 3.8? |
jacomago
force-pushed
the
pyprojecttoml
branch
5 times, most recently
from
June 17, 2024 08:23
c5f41cc
to
7893a4b
Compare
Update ci.yml dependencies Update pyproject.toml to add support down to 3.6 Update ci.yml to test down to 3.6
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
shroffk
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swaps the packaging to using pyproject.toml
Adds the test containers library for running tests with a containerized ChannelFinder
Adds testing to CI
Fixes the ChannelFinderClient tests for the current Channelfinder api.