Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use vfchost endpoint #16

Open
wants to merge 1 commit into
base: chameleoncloud/train
Choose a base branch
from
Open

use vfchost endpoint #16

wants to merge 1 commit into from

Conversation

mcevik0
Copy link

@mcevik0 mcevik0 commented May 10, 2022

added vfchost to operate on the primary corsa switch endpoints

diurnalist
diurnalist approved these changes May 10, 2022
View reviewed changes
Copy link

@diurnalist diurnalist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not clear on what problem this is solving

msherman64
msherman64 requested changes May 18, 2022
View reviewed changes
Copy link

@msherman64 msherman64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you add a more verbose commit message?

It would be helpful to have:

  1. what problem was happening
  2. why this change solves it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msherman64 msherman64 msherman64 requested changes

@diurnalist diurnalist diurnalist approved these changes

@paul-ruth paul-ruth Awaiting requested review from paul-ruth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcevik0 @diurnalist @msherman64